Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/987#discussion_r121616959
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java
---
@@ -123,4 +121,29 @@ public boolean isMemoryAvailable() {
public long getUsableMemory() {
return totalMemory - minimumMemory;
}
+
+ /**
+ * It tries to allocate memory of `size` bytes, keep retry until it
allocates successfully.
+ */
+ public static MemoryBlock allocateMemoryBlocking(long size) throws
MemoryException {
--- End diff --
Actually it is not a typo, I want to express this function will block
(retry) until it allocate memory successfully. Since this name is not good, I
will change it to `allocateMemoryWithRetry`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
