Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/995#discussion_r121883050
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
 ---
    @@ -193,13 +194,13 @@ private void 
compressDataMyOwnWay(ColumnWithShortIndex[] indexes) {
         map.add(counter);
         // if rle is index size is more than 70% then rle wont give any benefit
         // so better to avoid rle index and write data as it is
    -    boolean useRle = (((list.size() + map.size()) * 100) / indexes.length) 
< 70;
    +    boolean useRle = (((list.size() + map.size()) * 100) / 
dataWithRowId.length) < 70;
         if (useRle) {
    -      this.keyBlock = convertToKeyArray(list);
    -      dataIndexMap = convertToArray(map);
    +      this.dataPage = convertToKeyArray(list);
    --- End diff --
    
    convertToDataPage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to