Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1038#discussion_r122636342
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/SegmentTaskIndexStore.java
 ---
    @@ -233,8 +235,7 @@ private SegmentTaskIndexWrapper 
loadAndGetTaskIdToSegmentsMap(
                       taskIdToTableBlockInfoMap.entrySet().iterator();
                   long requiredSize =
                       calculateRequiredSize(taskIdToTableBlockInfoMap, 
absoluteTableIdentifier);
    -              segmentTaskIndexWrapper
    -                  .setMemorySize(requiredSize + 
segmentTaskIndexWrapper.getMemorySize());
    +
                   boolean isAddedToLruCache =
    --- End diff --
    
    Putting the segment cache object prior to loading the segment b-tree could 
    allow dirty read in case of concurrent query.
    Better to add the cache object after finishing the segment load.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to