Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1099#discussion_r125540172
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/DataMapStoreManager.java
---
@@ -69,20 +70,20 @@ public TableDataMap getDataMap(AbsoluteTableIdentifier
identifier, String dataMa
* @param mapType
* @return
*/
- public TableDataMap createTableDataMap(AbsoluteTableIdentifier
identifier, DataMapType mapType,
- String dataMapName) {
- Map<String, TableDataMap> map = dataMapMappping.get(mapType);
+ public AbstractTableDataMap createTableDataMap(AbsoluteTableIdentifier
identifier,
+ DataMapType mapType, String dataMapName) {
+ Map<String, AbstractTableDataMap> map = dataMapMappping.get(mapType);
if (map == null) {
map = new HashMap<>();
dataMapMappping.put(mapType, map);
}
- TableDataMap dataMap = map.get(dataMapName);
+ AbstractTableDataMap dataMap = map.get(dataMapName);
if (dataMap != null) {
throw new RuntimeException("Already datamap exists in that path with
type " + mapType);
}
try {
- //TODO create datamap using @mapType.getClassName())
+ dataMap = (AbstractTableDataMap)
(Class.forName(mapType.getClassName()).newInstance());
} catch (Exception e) {
LOGGER.error(e);
--- End diff --
should not ignore the exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
