Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1125#discussion_r125960197
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -327,6 +327,29 @@ private static AbsoluteTableIdentifier
getAbsoluteTableIdentifier(Configuration
return carbonSplits;
}
+ private BitSet setMatchedPartitions(String partitionIds, CarbonTable
carbonTable,
+ Expression filter) {
+ BitSet matchedPartitions = null;
+ if (null != partitionIds) {
+ String[] partList =
partitionIds.replace("[","").replace("]","").split(",");
+ matchedPartitions = new BitSet(Integer.parseInt(partList[0]));
+ for (String partitionId : partList) {
+ matchedPartitions.set(Integer.parseInt(partitionId));
+ }
+ } else {
+ if (null != filter) {
+ PartitionInfo partitionInfo =
+ carbonTable.getPartitionInfo(carbonTable.getFactTableName());
+ if (null != partitionInfo) {
+ Partitioner partitioner =
PartitionUtil.getPartitioner(partitionInfo);
+ matchedPartitions = new FilterExpressionProcessor()
+ .getFilteredPartitions(filter, partitionInfo, partitioner);
--- End diff --
I think we need modify getFilteredPartitions and FilterExpression to use
partition id instead of array index.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
