Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1238#discussion_r131575067
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
    @@ -26,13 +28,6 @@
     public interface DataMap {
     
       /**
    --- End diff --
    
    I think DataMapWriter should belong to DataMap, user should get writer from 
here. No need of seperate register for DataMapWriter as already 
DataMapStoreManager manages it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to