Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1238#discussion_r131575663
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapWriter.java ---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.carbondata.core.datamap.dev;
    +
    +import org.apache.carbondata.core.datamap.DataMapMeta;
    +import org.apache.carbondata.core.datastore.page.ColumnPage;
    +
    +/**
    + * Data Map writer
    + */
    +public interface DataMapWriter {
    +
    +  /**
    +   *  Start of new block notification.
    +   *  @param blockId file name of the carbondata file
    +   */
    +  void onBlockStart(String blockId);
    +
    +  /**
    +   * End of block notification
    +   */
    +  void onBlockEnd(String blockId);
    +
    +  /**
    +   * Start of new blocklet notification.
    +   * @param blockletId sequence number of blocklet in the block
    +   */
    +  void onBlockletStart(int blockletId);
    +
    +  /**
    +   * End of blocklet notification
    +   * @param blockletId sequence number of blocklet in the block
    +   */
    +  void onBlockletEnd(int blockletId);
    +
    +  /**
    +   * Add the column page row to the datamap
    +   * The order of pageId is not guranteed
    +   */
    +  void add(int blockletId, int pageId, ColumnPage page);
    +
    +  DataMapMeta getMeta();
    --- End diff --
    
    I think DataMapMeta should have belonged to DataMap/DataMapFactory not 
writer


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to