Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1179#discussion_r131702068
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/DataMapStoreManager.java
---
@@ -79,15 +79,15 @@ private TableDataMap
createTableDataMap(AbsoluteTableIdentifier identifier,
tableDataMaps = new ArrayList<>();
dataMapMappping.put(identifier, tableDataMaps);
}
- TableDataMap dataMap = getAbstractTableDataMap(dataMapName,
tableDataMaps);
+ TableDataMap dataMap = getTableDataMap(dataMapName, tableDataMaps);
if (dataMap != null) {
throw new RuntimeException("Already datamap exists in that path with
type " + mapType);
}
try {
DataMapFactory dataMapFactory =
mapType.getClassObject().newInstance();
dataMapFactory.init(identifier, dataMapName);
- dataMap = new TableDataMap(identifier, dataMapName, dataMapFactory);
+ dataMap = new TableDataMap(identifier, dataMapName, mapType,
dataMapFactory);
--- End diff --
rename `mapType` to `dataMapType`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
