Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1304#discussion_r136252580
--- Diff:
integration/spark-common/src/main/java/org/apache/carbondata/spark/load/CarbonLoaderUtil.java
---
@@ -258,92 +258,105 @@ public static void
deleteLocalDataLoadFolderLocation(CarbonLoadModel loadModel,
* @throws IOException
*/
public static boolean recordLoadMetadata(LoadMetadataDetails
newMetaEntry,
- CarbonLoadModel loadModel, boolean loadStartEntry, boolean
insertOverwrite)
+ CarbonLoadModel loadModel, boolean loadStartEntry, boolean
insertOverwrite, boolean isUpdate)
--- End diff --
Because should set carbonLoadModel in recordLoadMetadata(), otherwise the
below code in carbonTableSchema.scala will has NLP issue:
if (carbonLoadModel.getLoadMetadataDetails.isEmpty &&
carbonLoadModel.getUseOnePass &&
StringUtils.isEmpty(column_dict) &&
StringUtils.isEmpty(all_dictionary_path)) {
LOGGER.info(s"Cannot use single_pass=true for
$dbName.$tableName during the first load")
LOGGER.audit(s"Cannot use single_pass=true for
$dbName.$tableName during the first load")
carbonLoadModel.setUseOnePass(false)
}
in carbonTableSchema.scala , the below code need to
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
