[GitHub] carbondata pull request #1321: [CARBONDATA-1438] Unify the sort column and s...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1321#discussion_r136830112
  
    --- Diff: 
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestGlobalSortDataLoad.scala
 ---
    @@ -318,12 +329,12 @@ class TestGlobalSortDataLoad extends QueryTest with 
BeforeAndAfterEach with Befo
              | charField CHAR(5),
              | floatField FLOAT
              | )
    -         | STORED BY 'org.apache.carbondata.format'
    +         | STORED BY 'org.apache.carbondata.format' 
TBLPROPERTIES('SORT_SCOPE'='GLOBAL_SORT')
            """.stripMargin)
         sql(
           s"""
              | LOAD DATA LOCAL INPATH '$path' INTO TABLE 
carbon_globalsort_difftypes
    -         | OPTIONS('SORT_SCOPE'='GLOBAL_SORT',
    +         | OPTIONS(
              | 
'FILEHEADER'='shortField,intField,bigintField,doubleField,stringField,timestampField,decimalField,dateField,charField,floatField')
            """.stripMargin)
    --- End diff --
    
    Add a new testcase to test using SORT_SCOPE in LOAD DATA statement, it 
should fail


---