Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1297#discussion_r137270799
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/DefaultEncodingStrategy.java
---
@@ -130,7 +146,8 @@ private static DataType fitLongMinMax(long max, long
min) {
}
}
- private static DataType fitMinMax(DataType dataType, Object max, Object
min) {
+ private static DataType fitMinMax(DataType dataType, Object max, Object
min,
+ DecimalConverterFactory.DecimalConverterType decimalConverterType) {
--- End diff --
I think it is not good to pass `decimalConverterType` in many functions. It
makes code complex. It is better to think of a way to encapsulate it.
---
