Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1345#discussion_r138514170
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveFloatingCodec.java
 ---
    @@ -211,24 +199,23 @@ public long decodeLong(int value) {
           throw new RuntimeException("internal error: " + debugInfo());
         }
     
    -    @Override
    -    public double decodeDouble(byte value) {
    -      return BigDecimal.valueOf(value).divide(factor).doubleValue();
    +    @Override public double decodeDouble(byte value) {
    --- End diff --
    
    move @Override to previous line


---

Reply via email to