Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1336#discussion_r138555709
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/PartitionUtil.java
---
@@ -71,6 +72,10 @@ public static Object getDataBasedOnDataType(String data,
DataType actualDataType
default:
return data;
}
+ } catch (NumberFormatException ex) {
+ return new IllegalArgumentException(ex.getMessage());
--- End diff --
can throw MalformedCarbonException instead of runtime.
Its not good coding practice to return the exception object instead of
throwing it
---
