[GitHub] carbondata pull request #1359: [CARBONDATA-1480]Min Max Index Example for Da...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1359#discussion_r139058897
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapWriter.java ---
    @@ -32,7 +32,12 @@
       /**
        * End of block notification
        */
    -  void onBlockEnd(String blockId);
    +  void onBlockEnd(String blockId, String directoryPath);
    +
    +  /**
    +   * End of block notification when index got created.
    +   */
    +  void onBlockEndWithIndex(String blockId, String directoryPath);
    --- End diff --
    
    Why is this method required, why not `onBlockEnd` is enough?


---