Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1362#discussion_r139307286
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -271,6 +267,18 @@ private static ColumnPage
newIntPage(TableSpec.ColumnSpec columnSpec, int[] intD
return columnPage;
}
+ private static ColumnPage newBooleanPage(TableSpec.ColumnSpec
columnSpec, byte[] booleanData) {
+ ColumnPage columnPage = createPage(columnSpec, BOOLEAN,
booleanData.length);
--- End diff --
To make it simple, I think it is better to store boolean as byte in
ColumnPage, so you can create a ColumnPage of Byte type.
When come to encoding, you still can do proper encoding of this column page.
---
