Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1379#discussion_r140966782
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/AlterTableCompactionCommand.scala
 ---
    @@ -0,0 +1,91 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.command.management
    +
    +import org.apache.spark.sql.{CarbonEnv, Row, SparkSession}
    +import org.apache.spark.sql.execution.command.{AlterTableModel, 
DataProcessCommand, RunnableCommand}
    +import org.apache.spark.sql.hive.CarbonRelation
    +
    +import org.apache.carbondata.common.logging.{LogService, LogServiceFactory}
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +import org.apache.carbondata.processing.model.{CarbonDataLoadSchema, 
CarbonLoadModel}
    +import org.apache.carbondata.spark.rdd.CarbonDataRDDFactory
    +
    +/**
    + * Command for the compaction in alter table command
    + */
    +case class AlterTableCompactionCommand(
    +    alterTableModel: AlterTableModel)
    +  extends RunnableCommand with DataProcessCommand {
    +
    +  val LOGGER: LogService = 
LogServiceFactory.getLogService(this.getClass.getName)
    --- End diff --
    
    move LOGGER into the processData method
    better to keep all commands serializable for the cloud scenario


---

Reply via email to