Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1376#discussion_r141349763
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
 ---
    @@ -561,7 +567,7 @@ protected Expression getFilterPredicates(Configuration 
configuration) {
         return resultFilterredBlocks;
       }
     
    -  private org.apache.carbondata.hadoop.CarbonInputSplit 
convertToCarbonInputSplit(Blocklet blocklet)
    +  private CarbonInputSplit convertToCarbonInputSplit(DetailedBlocklet 
blocklet)
           throws IOException {
         blocklet.updateLocations();
         org.apache.carbondata.hadoop.CarbonInputSplit split =
    --- End diff --
    
    Why not just use `CarbonInputSplit` instead of 
`org.apache.carbondata.hadoop.CarbonInputSplit`


---

Reply via email to