[GitHub] carbondata pull request #1382: [CARBONDATA-1514] Sort Column Property is not...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1382#discussion_r141363530
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
 ---
    @@ -190,6 +190,14 @@ class AlterTableColumnSchemaGenerator(
     
       val LOGGER = LogServiceFactory.getLogService(this.getClass.getName)
     
    +  def checkSortColumn(columnName: String): Boolean = {
    +    val sortColumns = alterTableModel.tableProperties.get("sort_columns")
    +    if(sortColumns.isDefined) {
    +      sortColumns.get.contains(columnName)
    +    } else {
    +      true
    --- End diff --
    
    Shouldn't it be false?


---