Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1361#discussion_r143902837 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datacompaction/CompactionSupportGlobalSortFunctionTest.scala --- @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the"License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an"AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.carbondata.spark.testsuite.datacompaction + +import java.io.{File, FilenameFilter} + +import org.apache.spark.sql.Row +import org.apache.spark.sql.test.util.QueryTest +import org.scalatest.{BeforeAndAfterAll, BeforeAndAfterEach} + +import org.apache.carbondata.core.constants.CarbonCommonConstants +import org.apache.carbondata.core.util.CarbonProperties + +class CompactionSupportGlobalSortFunctionTest extends QueryTest with BeforeAndAfterEach with BeforeAndAfterAll { + val filePath: String = s"$resourcesPath/globalsort" + val file1: String = resourcesPath + "/globalsort/sample1.csv" + val file2: String = resourcesPath + "/globalsort/sample2.csv" + val file3: String = resourcesPath + "/globalsort/sample3.csv" + + override def beforeEach { + resetConf + sql("DROP TABLE IF EXISTS compaction_globalsort") + sql( + """ + | CREATE TABLE compaction_globalsort(id INT, name STRING, city STRING, age INT) + | STORED BY 'org.apache.carbondata.format' + | TBLPROPERTIES('SORT_COLUMNS'='city,name', 'SORT_SCOPE'='GLOBAL_SORT') + """.stripMargin) + + sql("DROP TABLE IF EXISTS carbon_localsort") + sql( + """ + | CREATE TABLE carbon_localsort(id INT, name STRING, city STRING, age INT) + | STORED BY 'org.apache.carbondata.format' + """.stripMargin) + } + + override def afterEach { + sql("DROP TABLE IF EXISTS compaction_globalsort") + sql("DROP TABLE IF EXISTS carbon_localsort") + } + + test("Compaction type: major") { + sql(s"LOAD DATA LOCAL INPATH '$file1' INTO TABLE carbon_localsort") + sql(s"LOAD DATA LOCAL INPATH '$file2' INTO TABLE carbon_localsort") + sql(s"LOAD DATA LOCAL INPATH '$file3' INTO TABLE carbon_localsort") + + sql(s"LOAD DATA LOCAL INPATH '$file1' INTO TABLE compaction_globalsort") + sql(s"LOAD DATA LOCAL INPATH '$file2' INTO TABLE compaction_globalsort") + sql(s"LOAD DATA LOCAL INPATH '$file3' INTO TABLE compaction_globalsort") + + sql("ALTER TABLE compaction_globalsort COMPACT 'MAJOR'") --- End diff -- I add some parameter tests for major compaction in CompactionSupportGlobalSortParameterTest.scala
---