Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1404#discussion_r144207692
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/loading/DataLoadProcessBuilder.java
 ---
    @@ -56,7 +56,7 @@ public AbstractDataLoadProcessorStep 
build(CarbonLoadModel loadModel, String[] s
           CarbonIterator[] inputIterators) throws Exception {
         CarbonDataLoadConfiguration configuration = 
createConfiguration(loadModel, storeLocation);
         SortScopeOptions.SortScope sortScope = 
CarbonDataProcessorUtil.getSortScope(configuration);
    -    if (!configuration.isSortTable() || 
sortScope.equals(SortScopeOptions.SortScope.NO_SORT)) {
    +    if (sortScope.equals(SortScopeOptions.SortScope.NO_SORT)) {
    --- End diff --
    
    I do not think this is the correct place to modify. You should correct the 
place where bad record logger is called


---

Reply via email to