Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1359#discussion_r144249578 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapWriter.java --- @@ -45,14 +45,13 @@ * @param blockletId sequence number of blocklet in the block */ void onBlockletEnd(int blockletId); - /** * Add the column pages row to the datamap, order of pages is same as `indexColumns` in * DataMapMeta returned in DataMapFactory. * * Implementation should copy the content of `pages` as needed, because `pages` memory * may be freed after this method returns, if using unsafe column page. */ - void onPageAdded(int blockletId, int pageId, ColumnPage[] pages); + void onPageAdded(int blockletId, int pageId, ColumnPage[] pages, String directoryPath); --- End diff -- This is not a directory path, instead the full path to the block. SO this is constant for a block. So removed it from OnPageAdded and passed as a extra parameter to OnBlockStart as this blockPath has to be initialized on every block start.
---