Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1425#discussion_r146496730
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/converter/SchemaConverter.java
---
@@ -100,4 +101,13 @@ TableSchema fromExternalToWrapperTableSchema(
*/
TableInfo
fromExternalToWrapperTableInfo(org.apache.carbondata.format.TableInfo
externalTableInfo,
String dbName, String tableName, String storePath);
+
+ /**
+ * method to convert thrift datamap schema object to wrapper
+ * data map object
+ * @param thriftchildSchema
+ * @return DataMapSchema
+ */
+ DataMapSchema fromExternalToWrapperChildSchema(
--- End diff --
change method name to reflect datamap in it
---