GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1432
[WIP][CARBONDATA-1608]Support Column Comment for Create Table
add column comment during carbon create table and when table is described
if comment is not mentioned, default comment will be null
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [*] Make sure the PR title is formatted like:
`[CARBONDATA-<Jira issue #>] Description of pull request`
- [*] Make sure to add PR description including
-create carbon table with column comment is added in this PR,
previously there was no option for column comment, now it has been added
-for implementing this, the parser has been edited to get column comment
and instead of checking its encoding technique to display in desc sql, we can
just show the comment for that specific column if any, if there are no comment
for the columns, the default value is null
- the root cause/problem statement
- What is the implemented solution
- [*] Any interfaces changed?
NONE
- [*] Any backward compatibility impacted?
NONE
- [*] Document update required?
NONE
- [*] Testing done
test cases are added for this
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
- [*] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akashrn5/incubator-carbondata col_comment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1432.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1432
----
commit 5cc41bfc4f117a5a1d6ff6bdc67fcb7ba61d343d
Author: akashrn5 <[email protected]>
Date: 2017-10-24T10:26:53Z
add column comment during carbon create table and when table is described
if comment is not mentioned, default will be null
----
---
