Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1417#discussion_r147639115
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java
 ---
    @@ -87,13 +88,6 @@
        */
       private int columnGroupId = -1;
     
    -  /**
    -   * Used when this column contains decimal data.
    -   */
    -  private int scale;
    -
    -  private int precision;
    --- End diff --
    
    I think there would be an issue while reading gson if we remove these 
fields. we will lose the data of it if we remove them. Better keep them for 
backward compatibility.


---

Reply via email to