Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1436#discussion_r147673675
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/BlockletDataMapIndexStore.java
---
@@ -66,13 +70,17 @@ public BlockletDataMapIndexStore(String
carbonStorePath, CarbonLRUCache lruCache
segmentLockMap = new ConcurrentHashMap<String, Object>();
}
- @Override public BlockletDataMap get(TableBlockIndexUniqueIdentifier
tableSegmentUniqueIdentifier)
+ @Override public BlockletDataMap get(TableBlockIndexUniqueIdentifier
identifier)
throws IOException {
- String lruCacheKey =
tableSegmentUniqueIdentifier.getUniqueTableSegmentIdentifier();
+ String lruCacheKey = identifier.getUniqueTableSegmentIdentifier();
BlockletDataMap dataMap = (BlockletDataMap) lruCache.get(lruCacheKey);
if (dataMap == null) {
try {
- dataMap = loadAndGetDataMap(tableSegmentUniqueIdentifier);
+ SegmentIndexFileStore indexFileStore = new SegmentIndexFileStore();
+
indexFileStore.readAllIIndexOfSegment(CarbonTablePath.getSegmentPath(
--- End diff --
Please move `CarbonTablePath.getSegmentPath(` to next line and make
indentation according to each function call
---
