Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1485#discussion_r150256214
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/streaming/CarbonStreamOutputFormat.java
 ---
    @@ -51,6 +51,14 @@
     
       private static final String LOAD_Model = 
"mapreduce.output.carbon.load.model";
     
    +  private static final String SEGMENT_ID = "carbon.segment.id";
    +
    +  public static final String HANDOFF_SIZE = "carbon.handoff.size";
    +
    +  public static final long HANDOFF_SIZE_MIN = 1024L * 1024 * 64;
    +
    +  public static final long HANDOFF_SIZE_DEFAULT = 1024L * 1024 * 1024;
    --- End diff --
    
    please add comment for these constants


---

Reply via email to