Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1494#discussion_r150854506
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/AlterTableCompactionCommand.scala
 ---
    @@ -128,11 +127,18 @@ case class AlterTableCompactionCommand(
           CommonUtil.readLoadMetadataDetails(carbonLoadModel)
         }
         if (compactionType == CompactionType.SEGMENT_INDEX_COMPACTION) {
    +      val mergeIndexProperty = CarbonProperties.getInstance()
    +        .getProperty(CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT)
    +      CarbonProperties.getInstance()
    --- End diff --
    
    Better pass the boolean to `CommonUtil.mergeIndexFiles` rather than setting 
to `CarbonProperties`


---

Reply via email to