Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1471#discussion_r151637482
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/dev/AbstractDataMapWriter.java
 ---
    @@ -0,0 +1,110 @@
    +/*
    --- End diff --
    
    Changed to Abstract class to enforce the user to pass the needed parameters 
through the constructor. And also the concrete method `commitFile` is added to 
this class.


---

Reply via email to