Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1538#discussion_r152741031
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java
---
@@ -141,24 +135,25 @@ public
SafeVariableLengthDimensionDataChunkStore(boolean isInvertedIndex, int nu
// for last record
length = (short) (this.data.length - currentDataOffset);
}
- DataType dt = vector.getType();
- if ((!(dt instanceof StringType) && length == 0) ||
ByteUtil.UnsafeComparer.INSTANCE
+ org.apache.carbondata.core.metadata.datatype.DataType dt =
vector.getType();
--- End diff --
why do this change ? remove import, add the full import at here ?
---
