[GitHub] carbondata pull request #1544: [CARBONDATA-1740] Fixed order by issue in cas...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1544#discussion_r153068779
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
 ---
    @@ -160,6 +155,90 @@ case class CarbonPreAggregateQueryRules(sparkSession: 
SparkSession) extends Rule
                 tableName,
                 list)
               carbonTable
    +        // case for handling aggregation, order by
    +        case Project(projectList, Sort(sortOrders, _, 
Aggregate(groupingExp,
    --- End diff --
    
    Can you avoid duplicate code by applying recursive call


---