Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1574#discussion_r153428387
  
    --- Diff: 
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/AlterTableTestCase.scala
 ---
    @@ -1067,7 +1067,7 @@ class AlterTableTestCase extends QueryTest with 
BeforeAndAfterAll {
       val p3 = 
prop.getProperty("carbon.horizontal.delete.compaction.threshold", 
CarbonCommonConstants.DEFAULT_DELETE_DELTAFILE_COUNT_THRESHOLD_IUD_COMPACTION)
       val p4 = prop.getProperty("carbon.compaction.level.threshold", 
CarbonCommonConstants.DEFAULT_SEGMENT_LEVEL_THRESHOLD)
       val p5 = prop.getProperty("carbon.enable.auto.load.merge", 
CarbonCommonConstants.DEFAULT_ENABLE_AUTO_LOAD_MERGE)
    -  val p6 = prop.getProperty("carbon.bad.records.action", 
CarbonCommonConstants.CARBON_BAD_RECORDS_ACTION_DEFAULT)
    +  val p6 = prop.getProperty("carbon.bad.records.action", "FORCE")
    --- End diff --
    
    instead of hard coding "FORCE" use enum LoggerAction.Force.name
    Do it everywhere you have made the code changes


---

Reply via email to