[GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1508#discussion_r153722923
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
 ---
    @@ -49,13 +50,54 @@ object LoadPostAggregateListener extends 
OperationEventListener {
                                     carbonLoadModel.getTableName, "false")
             val childTableName = 
dataMapSchema.getRelationIdentifier.getTableName
             val childDatabaseName = 
dataMapSchema.getRelationIdentifier.getDatabaseName
    -        val selectQuery = dataMapSchema.getProperties.get("CHILD_SELECT 
QUERY")
    -        sparkSession.sql(s"insert into $childDatabaseName.$childTableName 
$selectQuery")
    +        val childDataFrame = sparkSession.sql(new CarbonSpark2SqlParser()
    +          .addPreAggLoadFunction(s"${ 
dataMapSchema.getProperties.get("CHILD_SELECT QUERY") } "))
    +          .drop("preAggLoad")
    +        val headers = 
dataMapSchema.getChildSchema.getListOfColumns.asScala.map(_.getColumnName)
    --- End diff --
    
    move down


---