Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1544#discussion_r154662636
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
 ---
    @@ -232,7 +356,7 @@ case class CarbonPreAggregateQueryRules(sparkSession: 
SparkSession) extends Rule
       def getChildAttributeReference(dataMapSchema: DataMapSchema,
           attributeReference: AttributeReference,
           attributes: Seq[AttributeReference],
    -      aggFunction: String = ""): AttributeReference = {
    +      aggFunction: String = "", canBeNull: Boolean = false): 
AttributeReference = {
    --- End diff --
    
    move it down


---

Reply via email to