Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1594#discussion_r154825080
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala
 ---
    @@ -138,7 +138,7 @@ object DataLoadProcessorStepOnSpark {
     
           override def next(): CarbonRow = {
             val row =
    -          new CarbonRow(SortStepRowUtil.convertRow(rows.next().getData, 
sortParameters))
    +          new CarbonRow(sortStepRowUtil.convertRow(rows.next().getData))
    --- End diff --
    
    @jackylk yeah, actually in the further PRs (After #1606 ), I plan to rename 
it to `SortStepRowConverter`. This converter can also be used to directly write 
records to sort temp file.


---

Reply via email to