Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1613#discussion_r154977110
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/CreatePreAggregateTableCommand.scala
---
@@ -124,19 +122,15 @@ case class CreatePreAggregateTableCommand(
val loadAvailable =
SegmentStatusManager.readLoadMetadata(parentCarbonTable.getMetaDataFilepath)
.nonEmpty
if (loadAvailable) {
- val headers =
parentCarbonTable.getTableInfo.getFactTable.getListOfColumns.
- asScala.map(_.getColumnName).mkString(",")
- val childDataFrame = sparkSession.sql(
- new CarbonSpark2SqlParser().addPreAggLoadFunction(queryString))
- CarbonLoadDataCommand(tableIdentifier.database,
- tableIdentifier.table,
- null,
- Nil,
- Map("fileheader" -> headers),
- isOverwriteTable = false,
- dataFrame = Some(childDataFrame),
- internalOptions = Map(CarbonCommonConstants.IS_INTERNAL_LOAD_CALL
-> "true")).
- run(sparkSession)
+ // Passing segmentToLoad as * because we want to load all the
segments into the
+ // pre-aggregate table even if the user has set some segments on the
parent table.
+ PreAggregateUtil
+ .startDataLoadForDataMap(parentCarbonTable,
--- End diff --
follow coding style:
```
a.foo(
paramA,
paramB)
```
---
