Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1583#discussion_r155038052
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
 ---
    @@ -1044,48 +1045,48 @@ abstract class CarbonDDLSqlParser extends 
AbstractCarbonSparkSQLParser {
         dataType match {
           case "string" =>
             Field(field.column, Some("String"), field.name, Some(null), 
field.parent,
    -        field.storeType, field.schemaOrdinal, field.precision, 
field.scale, field.rawSchema
    -      )
    +        field.storeType, field.schemaOrdinal, field.precision, 
field.scale, field.rawSchema,
    +        field.columnComment)
           case "smallint" =>
             Field(field.column, Some("SmallInt"), field.name, Some(null),
               field.parent, field.storeType, field.schemaOrdinal,
    -          field.precision, field.scale, field.rawSchema)
    +          field.precision, field.scale, field.rawSchema, 
field.columnComment)
           case "integer" | "int" =>
             Field(field.column, Some("Integer"), field.name, Some(null),
               field.parent, field.storeType, field.schemaOrdinal,
    -          field.precision, field.scale, field.rawSchema)
    +          field.precision, field.scale, field.rawSchema, 
field.columnComment)
           case "long" => Field(field.column, Some("Long"), field.name, 
Some(null), field.parent,
    -        field.storeType, field.schemaOrdinal, field.precision, 
field.scale, field.rawSchema
    -      )
    +        field.storeType, field.schemaOrdinal, field.precision, 
field.scale, field.rawSchema,
    +        field.columnComment)
           case "double" => Field(field.column, Some("Double"), field.name, 
Some(null), field.parent,
    -        field.storeType, field.schemaOrdinal, field.precision, 
field.scale, field.rawSchema
    -      )
    +        field.storeType, field.schemaOrdinal, field.precision, 
field.scale, field.rawSchema,
    +        field.columnComment)
    --- End diff --
    
    this is needed as part of this pr only


---

Reply via email to