[GitHub] carbondata pull request #1624: [WIP][CARBONDATA-1867] Add support for task/s...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1624#discussion_r155232944
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
 ---
    @@ -101,6 +103,25 @@ public void addIndexRowToUnsafe(DataMapRow indexRow) 
throws MemoryException {
         pointers[rowCount++] = pointer;
       }
     
    +  /**
    +   * Add the task min/max row to unsafe.
    +   *
    +   * @param taskMinMaxRow
    +   * @return
    +   */
    +  public void addTaskMinMaxRowToUnsafe(DataMapRow taskMinMaxRow, 
List<Integer> indexesToAccess)
    --- End diff --
    
    why it is required a new method? why don't use `addToUnsafe`


---