Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1626#discussion_r155271321
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/preagg/AggregateTableSelector.java
 ---
    @@ -70,8 +70,15 @@ public AggregateTableSelector(QueryPlan queryPlan, 
CarbonTable parentTable) {
             AggregationDataMapSchema aggregationDataMapSchema = 
(AggregationDataMapSchema) dmSchema;
             isMatch = true;
             for (QueryColumn queryColumn : projectionColumn) {
    -          ColumnSchema columnSchemaByParentName = aggregationDataMapSchema
    -              
.getNonAggChildColBasedByParent(queryColumn.getColumnSchema().getColumnName());
    +          ColumnSchema columnSchemaByParentName = null;
    --- End diff --
    
    Please refactor to remove duplicate code


---

Reply via email to