[GitHub] carbondata pull request #1595: [CARBONDATA-1868][Spark-2.2]Carbon-Spark2.2 I...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1595#discussion_r155493105
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
 ---
    @@ -259,7 +259,7 @@ case class CarbonPreAggregateQueryRules(sparkSession: 
SparkSession) extends Rule
                 tableName,
                 list)
               // TODO need to handle filter predicate subquery scenario
    -//          isValidPlan = 
!PredicateSubquery.hasPredicateSubquery(filterExp)
    --- End diff --
    
    remove commented code


---