Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1601#discussion_r155713494
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
 ---
    @@ -190,7 +191,7 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf, parser: 
CarbonSpark2SqlParser)
         }
     
         val tableProperties = mutable.Map[String, String]()
    -    properties.foreach{property => tableProperties.put(property._1, 
property._2)}
    +    validatedProperties.foreach{property => 
tableProperties.put(property._1, property._2)}
    --- End diff --
    
    i think we can remove this code. After this we will extract the values so 
no point in creating mutable.Map. Can you please confirm this?


---

Reply via email to