Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1647#discussion_r156387038
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/CastExpressionOptimization.scala
 ---
    @@ -129,6 +143,13 @@ object CastExpressionOptimization {
                 } else {
                   Some(CastExpr(c))
                 }
    +          case s: ShortType if t.sameType(IntegerType) =>
    --- End diff --
    
    almost code is same in each case please try to refactor 


---

Reply via email to