Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1632#discussion_r156919460
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/NonDictionaryUtil.java ---
    @@ -108,60 +105,21 @@ public static Object getMeasure(int index, Object[] 
row) {
         return measures[index];
       }
     
    -  public static byte[] getByteArrayForNoDictionaryCols(Object[] row) {
    -
    -    return (byte[]) row[WriteStepRowUtil.NO_DICTIONARY_AND_COMPLEX];
    +  /**
    +   * Method to get the required non-dictionary & complex from 3-parted row
    +   * @param index
    +   * @param row
    +   * @return
    +   */
    +  public static byte[] getNonDictOrComplex(int index, Object[] row) {
    --- End diff --
    
    Rename the method to getNoDictOrComplex


---

Reply via email to