Github user lionelcao commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1661#discussion_r157131588
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/util/PartitionUtils.scala
 ---
    @@ -113,7 +113,8 @@ object PartitionUtils {
         }
     
         if (partitionId == 0) {
    -      partitionInfo.addPartition(splitInfo.size)
    +      val addedPartitionList = 
PartitionUtils.getListInfo(splitInfo.mkString(","))
    --- End diff --
    
    Looks like `add partition` of list partition table can only support string, 
but not string group. 
    If need to support string group, splitInfo should be List[List[String]] 
instead of List[String].
    Could you also change other places to support this feature and add test 
case?


---

Reply via email to