Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1679#discussion_r157746485
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
---
@@ -544,12 +543,7 @@ private int getKeySize(List<QueryDimension>
queryDimension,
}
UnsafeMemoryManager.INSTANCE.freeMemoryAll(ThreadLocalTaskInfo.getCarbonTaskInfo().getTaskId());
if (null != queryProperties.executorService) {
- queryProperties.executorService.shutdown();
- try {
- queryProperties.executorService.awaitTermination(1,
TimeUnit.HOURS);
- } catch (InterruptedException e) {
- throw new QueryExecutionException(e);
- }
+ queryProperties.executorService.shutdownNow();
--- End diff --
Please add a comment shutdownnow is called so in case of limit query when
number of limit records is already found so executors must stop all the running
execution otherwise it will keep running and will hit the query performance.
---
