GitHub user ManoharVanam opened a pull request:

    https://github.com/apache/carbondata/pull/1684

    [CARBONDATA-1912] Handling lock issues

    Description : 
    Getting error trace in spark-sql console while executing compaction and 
alter table rename commands.
    
    Scenario:
    execute compaction and alter table rename queries in spark - sql
    Even though operation is success , getting error trace on the console
    
    Solution: In compaction we are already handling unlock after operation , so 
we can handle unlock in catch block instead of finally block.
    In alter table rename operation: no need to unlock file on old location 
which will result error due to table name change.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests 
are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance 
test report.
            - Any additional information to help reviewers in testing this 
change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ManoharVanam/incubator-carbondata defect1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1684.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1684
    
----
commit c5c8fb08ca50845836e549ab5e42c506e0ace247
Author: Manohar <manohar.craz...@gmail.com>
Date:   2017-12-19T13:42:14Z

    We are unlocking lock file after compaction, so added unlock operation at 
required places.

----


---

Reply via email to