[GitHub] carbondata pull request #1678: [CARBONDATA-1903] Fix code issues in carbonda...

[xuchuanyin]

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1678#discussion_r157920314
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
 ---
    @@ -298,8 +298,7 @@ private void readAndLoadDataFromSortTempFiles() throws 
Exception {
             try {
               dataHandler.closeHandler();
             } catch (CarbonDataWriterException e) {
    -          LOGGER.error(e);
    -          throw new Exception("Problem loading data during compaction: " + 
e.getMessage());
    +          LOGGER.error(e, "Error in close data handler");
    --- End diff --
    
    It‘s better not to throw Exception in finally block, so we just swallow 
this exception.


---