[GitHub] carbondata pull request #1677: [CARBONDATA-1860][PARTITION] Support insertov...

[gvramana]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1677#discussion_r158015203
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
 ---
    @@ -567,14 +568,18 @@ case class CarbonLoadDataCommand(
               carbonLoadModel,
               sparkSession)
         }
    -    Dataset.ofRows(
    -      sparkSession,
    +    val convertedPlan =
           CarbonReflectionUtils.getInsertIntoCommand(
             convertRelation,
             partition,
             query,
    -        isOverwriteTable,
    -        false))
    +        false,
    +        false)
    +    if (isOverwriteTable && partition.nonEmpty && 
table.isHivePartitionTable) {
    --- End diff --
    
    isHivePartitionTable command check is not required as it is already done


---