Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1710#discussion_r158467171
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
    @@ -1241,15 +1243,28 @@ public static Dictionary getForwardDictionaryCache(
           AbsoluteTableIdentifier dictionarySourceAbsoluteTableIdentifier,
           CarbonDimension carbonDimension, TableProvider tableProvider) throws 
IOException {
         String dictionaryPath = null;
    +    ColumnIdentifier columnIdentifier = 
carbonDimension.getColumnIdentifier();
         if (null != tableProvider) {
           CarbonTable carbonTable = tableProvider
               
.getCarbonTable(dictionarySourceAbsoluteTableIdentifier.getCarbonTableIdentifier());
           dictionaryPath = 
carbonTable.getTableInfo().getFactTable().getTableProperties()
               .get(CarbonCommonConstants.DICTIONARY_PATH);
    +      if (null != 
carbonDimension.getColumnSchema().getParentColumnTableRelations() &&
    --- End diff --
    
    here size check is also required when aggregate table is mapped to single 
parent column then only it will use table column dictionary otherwise it will 
use its own dictionary better to add a check size of parentcolumntablerelations 
is 1


---

Reply via email to