Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1716#discussion_r158574266
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CarbonScalaUtil.scala
---
@@ -158,7 +159,9 @@ object CarbonScalaUtil {
dataType: DataType,
timeStampFormat: SimpleDateFormat,
dateFormat: SimpleDateFormat,
- serializationNullFormat: String): UTF8String = {
+ serializationNullFormat: String,
+ failAction: Boolean,
+ ignoreAction: Boolean): UTF8String = {
--- End diff --
It is not easy to understand why there is bad record related parameter in
this conversion function, can you catch exception in caller and handler it
there? There is only one place call this function, and it is better to restrict
its scope by moving it there
---
