[GitHub] carbondata pull request #1707: [CARBONDATA-1839] [DataLoad] Fix bugs and opt...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1707#discussion_r158900586
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
 ---
    @@ -315,6 +319,49 @@ public boolean delete() {
         return new DataInputStream(new BufferedInputStream(stream));
       }
     
    +  @Override public DataInputStream getDataInputStream(String path, 
FileFactory.FileType fileType,
    --- End diff --
    
    It already has a method in this class which chooses codec depends on the 
extension, Better use that instead of duplicating.


---